Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backport: disable no-squash with backport-squash label #1430

Merged
merged 1 commit into from
Mar 8, 2024

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Mar 6, 2024

Changes proposed

  1. Made no-squash option configurable, by default is set to true (i.e., using label backport) but if you want to force no-squash: false for any reason you can simply add label backport-squash rather than backport one.
  2. Added concurrency so that if multiple jobs are triggered targeting the same PR only one will be kept alive

Check List (Check all the applicable boxes)

  • My code follows the code style of this project.
  • My change requires changes to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed.

@lampajr
Copy link
Member Author

lampajr commented Mar 6, 2024

@johnaohara maybe this is just temporarily needed but I think that having this option enabled could be useful for the future (don't know maybe there will be other use cases where we would like to disable no-squash)

@lampajr lampajr force-pushed the squash_backport_configurable branch from ad6d45c to 6b48f5d Compare March 7, 2024 14:28
@johnaohara johnaohara merged commit 4db31ff into Hyperfoil:master Mar 8, 2024
2 checks passed
@johnaohara
Copy link
Member

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants