-
Notifications
You must be signed in to change notification settings - Fork 31
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[0.11.x] Bump @types/react-table from 7.7.14 to 7.7.19 in /horreum-web #1373
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
CI errors occured becasue we need to make change in package.json
file then npm i
to update version in lock
file
see current version in package.json
-
Horreum/horreum-web/package.json
Line 17 in 45e9cf7
"@types/react-table": "7.7.14", |
@shivam-sharma7 what has happened here is there were 2 commits in the original PR, but the backport bot has only applied one of them |
45e9cf7
to
0c96bad
Compare
but now npm has removed all the esbuild native binaries again: https://github.com/Hyperfoil/Horreum/pull/1373/files#diff-7bd5bcb1bbc7060dbc4c33ca2164d862273f7518582df29baefca7f356f8daaaL411 so this will fail on windows |
@johnaohara Its failing for only 11.x not for master because I have tested for master we have to figure it out. I will look at tomorrow |
it is failing in this PR, because npm has removed the native windows dependencies |
please, can you re-build |
this is exactly what I have done, but see my previous comments |
@johnaohara we need to install the following module in "node_modules/@rollup/rollup-win32-arm64-msvc": {
"version": "4.9.6",
"resolved": "https://registry.npmjs.org/@rollup/rollup-win32-arm64-msvc/-/rollup-win32-arm64-msvc-4.9.6.tgz",
"integrity": "sha512-VD6qnR99dhmTQ1mJhIzXsRcTBvTjbfbGGwKAHcu+52cVl15AC/kplkhxzW/uT0Xl62Y/meBKDZvoJSJN+vTeGA==",
"cpu": [
"arm64"
],
"optional": true,
"os": [
"win32"
]
}, |
0c96bad
to
4df8b65
Compare
Bumps [@types/react-table](https://github.com/DefinitelyTyped/DefinitelyTyped/tree/HEAD/types/react-table) from 7.7.14 to 7.7.19. - [Release notes](https://github.com/DefinitelyTyped/DefinitelyTyped/releases) - [Commits](https://github.com/DefinitelyTyped/DefinitelyTyped/commits/HEAD/types/react-table) --- updated-dependencies: - dependency-name: "@types/react-table" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <[email protected]> re-run npm i
4df8b65
to
10bb241
Compare
Backport: #1285
Bumps @types/react-table from 7.7.14 to 7.7.19.
Commits
Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting
@dependabot rebase
.Dependabot commands and options
You can trigger Dependabot actions by commenting on this PR:
@dependabot rebase
will rebase this PR@dependabot recreate
will recreate this PR, overwriting any edits that have been made to it@dependabot merge
will merge this PR after your CI passes on it@dependabot squash and merge
will squash and merge this PR after your CI passes on it@dependabot cancel merge
will cancel a previously requested merge and block automerging@dependabot reopen
will reopen this PR if it is closed@dependabot close
will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually@dependabot show <dependency name> ignore conditions
will show all of the ignore conditions of the specified dependency@dependabot ignore this major version
will close this PR and stop Dependabot creating any more for this major version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this minor version
will close this PR and stop Dependabot creating any more for this minor version (unless you reopen the PR or upgrade to it yourself)@dependabot ignore this dependency
will close this PR and stop Dependabot creating any more for this dependency (unless you reopen the PR or upgrade to it yourself)