[0.11.x] closes #1312 with updated UIService api #1316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport: #1315
Closes #1312
The
UIServiceupdateViewnow returns the updatedViewnot just theidbecause the updated view can contain newViewComponentsand the client needs to know the newidsfor thoseViewComponentsAn alternative could be to fetch all the
Viewsafter updating anyViewbut that would re-fetch data that did not change. It might simplify the client code but would add unnecessary IO to the backend. I think there are better improvements to be made to the client code with where and how views are cached in the javascript but that is for a later PR.