Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Security migration - Fixes #1261 #1309

Merged
merged 1 commit into from
Mar 4, 2024

Conversation

barreiro
Copy link
Collaborator

@barreiro barreiro commented Feb 9, 2024

Adds service that performs migration of roles from keycloak to horreum DB.

Depends on the new security model #1304

Fixes #1261

@barreiro barreiro force-pushed the security-migration branch 2 times, most recently from 4ba8a59 to 00e6125 Compare February 9, 2024 17:01
@johnaohara
Copy link
Member

@luis does this PR fix this issue: #1188 ?

@johnaohara
Copy link
Member

@barreiro or this issue that you opened: #1261

@barreiro barreiro changed the title Security migration Security migration - Fixes #1261 Feb 22, 2024
@barreiro barreiro marked this pull request as ready for review February 22, 2024 17:18
@johnaohara
Copy link
Member

johnaohara commented Feb 23, 2024

@barreiro looking at this PR, i thought it was independent of #1304 (which I have already merged)

However, both PR's make the same changes to the DB changelog.xml, with the same ID's.

Which PR should have been merged first? Can you fix this PR so that it does not have conflicting DB changes?

@barreiro
Copy link
Collaborator Author

@johnaohara rebased

@barreiro barreiro force-pushed the security-migration branch from 338a9b0 to 8ff7f6e Compare March 2, 2024 18:23
@johnaohara johnaohara merged commit 2b2fb96 into Hyperfoil:master Mar 4, 2024
2 checks passed
@johnaohara johnaohara modified the milestone: 0.16 Release Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Migration strategy for roles
2 participants