Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[0.11.x] Display datastore config to managers in Admin tab: Fixes #1275 #1277

Merged
merged 1 commit into from
Feb 6, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 3 additions & 2 deletions horreum-web/src/App.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ import {
import {Provider, useSelector} from "react-redux"

import store from "./store"
import {isAdminSelector, LoginLogout} from "./auth"
import {isAdminSelector, isManagerSelector, LoginLogout} from "./auth"
import {initKeycloak} from "./keycloak"
import {UserProfileLink, UserSettings} from "./domain/user/UserSettings"

Expand Down Expand Up @@ -92,6 +92,7 @@ export default function App() {

function Main() {
const isAdmin = useSelector(isAdminSelector)
const isManager = useSelector(isManagerSelector)


return (
Expand Down Expand Up @@ -120,7 +121,7 @@ function Main() {
<NavItem itemId={3}>
<NavLink to="/reports">Reports</NavLink>
</NavItem>
{isAdmin && (
{ (isAdmin || isManager) && (
<NavItem itemId={4}>
<NavLink to="/admin">Administration</NavLink>
</NavItem>
Expand Down
4 changes: 4 additions & 0 deletions horreum-web/src/auth.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -111,6 +111,10 @@ export const isAdminSelector = (state: State) => {
return state.auth.roles.includes("admin")
}

export const isManagerSelector = (state: State) => {
return managedTeamsSelector(state).length > 0
}

export const teamsSelector = (state: State): string[] => {
return state.auth.teams
}
Expand Down
31 changes: 26 additions & 5 deletions horreum-web/src/domain/admin/Admin.tsx
Original file line number Diff line number Diff line change
@@ -1,22 +1,28 @@
import { useRef } from "react"
import { Card, CardBody, PageSection } from "@patternfly/react-core"
import {useRef} from "react"
import {Card, CardBody, NavItem, PageSection} from "@patternfly/react-core"

import SavedTabs, { SavedTab, TabFunctions, saveFunc, resetFunc, modifiedFunc } from "../../components/SavedTabs"
import { FragmentTab } from "../../components/FragmentTabs"
import SavedTabs, {SavedTab, TabFunctions, saveFunc, resetFunc, modifiedFunc} from "../../components/SavedTabs"
import FragmentTabs, {FragmentTab} from "../../components/FragmentTabs"
import AllowedSiteList from "../actions/AllowedSiteList"
import ActionList from "../actions/ActionList"
import BannerConfig from "./BannerConfig"
import Notifications from "./Notifications"
import Teams from "./Teams"
import Administrators from "./Administrators"
import {useSelector} from "react-redux";
import {isAdminSelector} from "../../auth";
import {isAdminSelector, isManagerSelector} from "../../auth";
import Datastores from "./Datastores";
import {NavLink} from "react-router-dom";
import DatasetData from "../runs/DatasetData";
import RunData from "../runs/RunData";
import MetaData from "../runs/MetaData";

export default function Admin() {
const adminFuncsRef = useRef<TabFunctions>()
const teamsFuncsRef = useRef<TabFunctions>()
const isAdmin = useSelector(isAdminSelector)
const isManager = useSelector(isManagerSelector)

if (isAdmin) {
return (
<PageSection>
Expand Down Expand Up @@ -60,6 +66,21 @@ export default function Admin() {
</Card>
</PageSection>
)
} else if (isManager) {
return (
<PageSection>
<Card>
<CardBody>
<FragmentTabs>
<FragmentTab title="Datastores" fragment="datastores">
<Datastores/>
</FragmentTab>
</FragmentTabs>
</CardBody>
</Card>
</PageSection>
)

} else {
return (
<PageSection>
Expand Down
Loading