Changed default ordering to Decending and preserve ordering of DTOs. #1263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
whitingjr
force-pushed
the
fix-default-list-ordering-dataset-runs-929
branch
from
7e1f85a to
c9c3883
Compare
johnaohara
reviewed
Feb 7, 2024
horreum-backend/src/main/java/io/hyperfoil/tools/horreum/svc/RunServiceImpl.java
Outdated
Show resolved
Hide resolved
…jects to UI. fixes 929 issue.
whitingjr
force-pushed
the
fix-default-list-ordering-dataset-runs-929
branch
from
c9c3883 to
0b8d949
Compare
stalep
approved these changes
Feb 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Preserves DTO object ordering to UI.
Fixes Issue
fixes #929 issue
Changes proposed
[x] - Add testcase to check Runs ordering in ASC or DESC mode.
[x] - Add testcase to check Datasets ordering in ASC or default DESC mode.
[x] - Fix the default ordering to Descending
[x] - Fixs the loss of ordering when creating a list of DTO objects
Check List (Check all the applicable boxes)