Fix conflicting npm dependencies and bump typescript 4 to 5 : Fixes #1182 #1224
+61
−64
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johnaohara
requested changes
Jan 31, 2024
shivarm
force-pushed
the
fix-npm-conflict
branch
5 times, most recently
from
0a755d1 to
788eb94
Compare
shivarm
force-pushed
the
fix-npm-conflict
branch
from
788eb94 to
3c58b59
Compare
|
@johnaohara let's merge it |
@shivam-sharma7 , I am really sorry, I merged in another PR before this and there is a conflict with package-lock.json again I am going to fix the package-lock.json issue and mere. We seem to have a problem with some PR's that the entire package-lock.json is re-written with a different number of spaces, which means the entire file is replaced |
johnaohara
approved these changes
Feb 2, 2024
johnaohara
added a commit
that referenced
this pull request
Feb 2, 2024
* Fix conflicting npm dependencies and bump typescript 4 to 5 * Fix package-lock.json format --------- Co-authored-by: John O'Hara <[email protected]>
4 tasks
|
Merged, Thanks for your contribution. |
johnaohara
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Issue #1182
Changes proposed
Check List (Check all the applicable boxes)