[Feat] Add game title to QuestDetailsWrapper component #52
Conversation
biliesilva
requested review from
jiyuu-jin,
flavioislima,
BrettCleary,
eliobricenov and
ry-animal
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
got some conflicts to resolve on this one @biliesilva |
…into feat]-Add-game-title-to-QuestDetailsWrapper
| @@ -152,8 +158,8 @@ export function QuestDetailsWrapper(props: QuestDetailsWrapperProps) { | |||
| 'Connect Steam account' | |||
| ), | |||
| questType: { | |||
| REPUTATION: t('quest.type.reputation', 'Reputation'), | |||
There was a problem hiding this comment.
we need to keep the reputation translation string
| REPUTATION: t('quest.type.reputation', 'Reputation'), | ||
| PLAYSTREAK: t('quest.type.playstreak', 'Play Streak') | ||
| PLAYSTREAK: t('quest.type.playstreak', 'Play Streak'), | ||
| GAME: gameName |
There was a problem hiding this comment.
game isn't a quest type. did you mean to add this prop somewhere else?
There was a problem hiding this comment.
These are two different badges, one is the type of quest, and the other is the game name.
| @@ -68,6 +72,8 @@ export function QuestDetailsWrapper(props: QuestDetailsWrapperProps) { | |||
|
|
|||
| const questResult = useGetQuest(selectedQuestId, getQuest) | |||
| const questMeta = questResult.data?.data | |||
| const projectId = questMeta?.project_id | |||
| const gameName = projectId && listings?.[projectId]?.project_meta?.name | |||
There was a problem hiding this comment.
could we just pass in listings?.[projectId]?.project_meta?.name as game name as a prop to this component instead of passing the whole listings object?
There was a problem hiding this comment.
It is a lot of data to pass around if we have to pass the listings object here too. This will probably be hard to adopt in store and client since they can use different listings interfaces
There was a problem hiding this comment.
So, this was something I was talking with @eliobricenov about, I will ping your conversations about it.
Description
Added the game listings directly to the badge in the component, next step is to update the client for this lib.
Storybook
Design Link