-
Notifications
You must be signed in to change notification settings - Fork 68
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subscribe to existing SNS topic #94
Comments
Can you check, if the SNS subscription is placed into the alias stack? It should be created there, because the alias is subscribed and not $LATEST. Did it also not show up when you inspect the aliased version of the lambda instead of $LATEST? |
I actually see the AWS::SNS::Subscription resource on the non-aliased stack and to further validate when looking at the subscription registered on the SNS topic it doesn't look it has the alias on the end of the arn. |
Also should mention that this is just a straight sls deploy without specifying an explicit alias so this is for the default alias dev. |
Ok. Then this is a bug in the plugin, that it does not adjust the subscription to point to the alias. Additionally, the alias should have a permissions object attached. Can you post the relevant parts of your serverless.yml, just to be sure? |
Here is the entire serverless.yml. I went ahead and replicated using a sample project that I created. service: serverless-alias-test plugins:
provider: functions: |
… to an existing SNS topic
Added support to have an alias subscribe to an existing SNS topic #94
Released with 1.6.0 |
I'm getting sporadic failures of a similar nature. Click on 'Fix' then 'Save' does indeed fix the issue, but having to add a manual verification of SNS subscriptions to our deployment process obviously sucks. Context: I have a |
… to an existing SNS topic
…n-fix Added support to have an alias subscribe to an existing SNS topic serverless-heaven#94
I am trying to subscribe to an existing SNS topic with the serverless-aws-alias plugin installed. When using an existing SNS topic it doesn't look like the subscription is actually created. I was able to replicate this using serverless 1.25 and serverless-aws-alias 1.5.1.
When navigating to the lambda alias and looking at the SNS trigger a message is shown on the bottom stating
"A subscription for arn on the topic topic name could not be found". The console gives an option to fix or delete.
Under CloudFormation resources I do not see an AWS::SNS::Subscription defined either.
It does work as expected with the alias plugin commented out in serverless.yml
The text was updated successfully, but these errors were encountered: