Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getter and setter addition for saturation. Enchanted golden apple works #963

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

ZloyNick
Copy link

@ZloyNick ZloyNick commented May 4, 2020

This commit adds 2 get|set methods:
Player::getSaturation();
Player::setSaturation($val);

and makes Enchanted Golden Apples are workable.

This commit adds 2 get|set methods:
    Player::getSaturation();
    Player::setSaturation($val);

and makes Enchanted Golden Apples are workable.
@yoraze
Copy link

yoraze commented May 4, 2020

#926 (comment)

@Dexveloper
Copy link

You made a typo in line 2888

@ImDaRealAni
Copy link

ImDaRealAni commented May 4, 2020

#926 (comment)
Hydreon never merges public PRs anymore.

@ZloyNick
Copy link
Author

ZloyNick commented May 5, 2020

You made a typo in line 2888

Fixed. Thanks.

@IceCruelStuff
Copy link

Maybe you should use public function getSaturation(): float and
public function setSaturation(float $sat)

@ZloyNick
Copy link
Author

Maybe you should use public function getSaturation(): float and
public function setSaturation(float $sat)

SteadFast2 haven't types declaration.

@dktapps
Copy link
Member

dktapps commented May 10, 2020

This PR is a waste of time as pointed out by myself in the comment linked above, which, you might notice, was given a 👍 by one of the Steadfast maintainers. So, it really makes no difference whether you apply those type hints or not.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants