Update KordEx, Kotlin, Gradle, fix small K2 warnings

[gdude2002]

This PR makes the following changes:

• Update Kotlin to 2.0.10
• Update KordEx to version 2 - please note that it seems Reposilite might not maintain old snapshots
• Update Gradle to 8.10
• Add an explicit Java source/target compatibility block in the build script, to make sure it's consistent with the Kotlin configuration
• Fix a few small warnings surfaced by the K2 compiler (e.g. unnecessary non-null assertions)
• Configure the about command - happy to update this if it doesn't suit

When working in K2 mode going forward, please note that K2 mode in the IntelliJ Kotlin Plugin is buggy and may incorrectly complain about suspending function calls within non-suspending functions, even when the enclosing block is suspending.

[NoComment1105]

It's looking good, did you run the gradle wrapper update twice? I see the jar change but no change to scripts. What is the point of the dev task? What's the issue with the run task?

[gdude2002]

I ran it a bunch of times wondering about the script changes too, but nope, there's no script changes this time apparently?

The run task is part of the application plugin, which is responsible for setting up your project's main distribution. Configuring the application plugin to run the bot with the devMode property means that it'll also be set in your production distributions, which is probably not something you actually want.

[NoComment1105]

What is the point of the dev mode property then. Why is it suddenly "needed"

[gdude2002]

It's just an automatic way to turn on dev mode, which is exposed as a property in your bot builder (devMode). It's a small feature that was added in KordEx 2 that would usually be handled by the Gradle plugin - mostly intended to allow bots to conditionally run extra debugging code or whatever in development.

More info on the other ways to set it can be found here if preferred.

[NoComment1105]

If it's a bot builder property, could you remove this task and use the environment variable we already have to set it instead. The variable is either development or production so you'll need to check the string.

[gdude2002]

Yeah sure, let me check on that.

[gdude2002]

It looks like you set that by setting ENVIRONMENT to development? Is that correct?

[NoComment1105]

Yep that's correct

[gdude2002]

Ah, well in that case KordEx will detect it automatically, so no need for the task.

[gdude2002]

Ah wait I forgot to do something, don't merge this yet

[gdude2002]

Alright, sorted that and updated the PR description with a screenshot.

I'd recommend quickly reading the docs to learn what you can actually do with the about command, but I pretty much just moved the existing one over for now.

[NoComment1105]

I'd like to see all the emojis removed from the buttons and the title set back to what the original embed showed please.

[gdude2002]

Sure thing, I'll get on that after work tomorrow

…

On 18 Aug 2024, 23:09 +0100, NoComment ***@***.***>, wrote: I'd like to see all the emojis removed from the buttons and the title set back to what the original embed showed please. — Reply to this email directly, view it on GitHub, or unsubscribe. You are receiving this because you authored the thread.Message ID: ***@***.***>

[gdude2002]

I've done that and updated the PR comment to correspond.

[gdude2002]

Oh? It's missing a snapshot? That can't be right..

[gdude2002]

Alright, well I turned on the option to preserve old snapshots last night, but it seems Reposilite didn't actually save that, so it still deleted the snapshot this PR was building against. I'm gonna poke the Reposilite Discord and ask.

[gdude2002]

Currently blocked by HyacinthBots/doc-generator#10

No longer blocked

[gdude2002]

Are we finally there? I think we might be!

[NoComment1105]

Excellent, thanks