-
-
Notifications
You must be signed in to change notification settings - Fork 69
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ wip ] Waybar Rework #215
Open
kRHYME7
wants to merge
18
commits into
master
Choose a base branch
from
waybar_ultimate_rework
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
feat: - Style selection - Layout Selection - Can override layout by using ~/.config/waybar/config - Modify waybar manually - have extra groups styling, this is the pill like groupings/islands in hyprdots - menus - see todos todo: - [ ] Script to handle dynamic stuff - [ ] Docs - [ ] Menu to change wayabr layout and style and more++ - [ ] Dynamic borderradisu according to rounding - [ ] Dynamic shadows according to compositor - [ ] Port hyprdots and other layouts and style - [ ] Have fun! why? - hyprdots waybar configuration is too limiting. - Also giving users easy interface like the config.ctl is practically okayish, but learning json/c a is much better and opens more window of ideas. To compensate with that a selector will be used to naviagte through layouts and styles. - New imple adheres to wayabr documentation and some gtk stuff which you search engine and your A! can answer for you.
Sync any existing files/ files in directories: modules styles layouts menus config.jsonc theme.css style.css Populates only when missing else preserve user-style.css
What's your overall vision and how exactly does the new approach works, do you intend it to work. It's complicate to write docs for something you ain't know how it works... |
This PR might be staled until this I guess I should build this on stable. |
…ybar_ultimate_rework
…ybar_ultimate_rework
dieBakterie
reviewed
Feb 10, 2025
This was referenced Feb 11, 2025
…ect/hyde into waybar_ultimate_rework
…ybar_ultimate_rework
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request: Native Waybar Configuration & Enhanced Management
Main Objective:
To provide a more flexible and user-friendly Waybar configuration experience by leveraging native Waybar features and CSS styling, while also offering a robust wrapper script for enhanced management.
Key Features and Benefits:
Native Waybar Configuration:
Waybar Wrapper Script:
--next
,--prev
,--config
,--style
,--select
,--watch
, and--update
.--select
to launch a Rofi menu for easy layout and style selection.--watch
option will relaunch Waybar if killed.Implemented Features (feat):
~/.config/waybar/config
border-radius
(according to rounding)To Do (todo):
Why This Approach?
config.ctl
is helpful, directly using JSON/CSS offers greater flexibility and creative possibilities. A selector script will compensate for the ease of use ofconfig.ctl
by providing a simple way to navigate layouts and styles.Preview
Available groups that can dynamically scaled across 4 positions
waybar has a selector that determines the bar position.
leaf-reverse
leaf
pill
pill-up pill-left pill-right pill-down
These are the half pill that the curve points to
pill-in pill-out
These are the half pill but the curves always points inner or outer.
![image](https://private-user-images.githubusercontent.com/53417443/411324420-34a47735-b14e-4e7f-8491-5a834ae82cb9.png?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3Mzk2NzA2MzksIm5iZiI6MTczOTY3MDMzOSwicGF0aCI6Ii81MzQxNzQ0My80MTEzMjQ0MjAtMzRhNDc3MzUtYjE0ZS00ZTdmLTg0OTEtNWE4MzRhZTgyY2I5LnBuZz9YLUFtei1BbGdvcml0aG09QVdTNC1ITUFDLVNIQTI1NiZYLUFtei1DcmVkZW50aWFsPUFLSUFWQ09EWUxTQTUzUFFLNFpBJTJGMjAyNTAyMTYlMkZ1cy1lYXN0LTElMkZzMyUyRmF3czRfcmVxdWVzdCZYLUFtei1EYXRlPTIwMjUwMjE2VDAxNDUzOVomWC1BbXotRXhwaXJlcz0zMDAmWC1BbXotU2lnbmF0dXJlPWNmZjEzYTc5Y2QzMTdkNzE4YTk3NWI5YjUxZjQzMDg1NGQ1YzYxMmFhNWEwZTA0NjRmZDFhYjZhZjA1OTRhZDMmWC1BbXotU2lnbmVkSGVhZGVycz1ob3N0In0.LQWTGFCHWJKqyFD9kkq7WmfJwKW9jBfNeeqZDyiACus)
Menus
Known Issues
Image icons won't dynamically scale and should be added in the
config.json
instead of css.To mitigate this, all modules that is using image icons are required to be written as
json
instead ofjsonc
. This way the helper script will parse allicon-size
key and dynamically scale the icons. This is the cleanest way I know atm.GTK theming issues. Some gtk themes have a weird border in it. Dunno how to fix yet as the problems are in the gtk theme itself.