missing GraphQL value escaping

Husqvik · Feb 4, 2023 · 913a369 · 913a369
1 parent e5e1c14
commit 913a369
Show file tree

Hide file tree

Showing 4 changed files with 4 additions and 4 deletions.
diff --git a/src/GraphQlClientGenerator/BaseClasses.cs b/src/GraphQlClientGenerator/BaseClasses.cs
@@ -193,7 +193,7 @@ value is IFormattable formattable
         if (value is short || value is ushort || value is byte || value is int || value is uint || value is long || value is ulong || value is float || value is double || value is decimal)
             return Convert.ToString(value, CultureInfo.InvariantCulture);
 
-        var argumentValue = Convert.ToString(value, CultureInfo.InvariantCulture);
+        var argumentValue = EscapeGraphQlStringValue(Convert.ToString(value, CultureInfo.InvariantCulture));
         return $"\"{argumentValue}\"";
     }
 

diff --git a/test/GraphQlClientGenerator.Test/ExpectedSingleFileGenerationContext/FullClientCSharpFile b/test/GraphQlClientGenerator.Test/ExpectedSingleFileGenerationContext/FullClientCSharpFile
@@ -213,7 +213,7 @@ namespace GraphQlGenerator.Test
             if (value is short || value is ushort || value is byte || value is int || value is uint || value is long || value is ulong || value is float || value is double || value is decimal)
                 return Convert.ToString(value, CultureInfo.InvariantCulture);
 
-            var argumentValue = Convert.ToString(value, CultureInfo.InvariantCulture);
+            var argumentValue = EscapeGraphQlStringValue(Convert.ToString(value, CultureInfo.InvariantCulture));
             return $"\"{argumentValue}\"";
         }
 

diff --git a/test/GraphQlClientGenerator.Test/ExpectedSingleFileGenerationContext/SourceGeneratorResult b/test/GraphQlClientGenerator.Test/ExpectedSingleFileGenerationContext/SourceGeneratorResult
@@ -213,7 +213,7 @@ namespace SourceGeneratorTestAssembly
             if (value is short || value is ushort || value is byte || value is int || value is uint || value is long || value is ulong || value is float || value is double || value is decimal)
                 return Convert.ToString(value, CultureInfo.InvariantCulture);
 
-            var argumentValue = Convert.ToString(value, CultureInfo.InvariantCulture);
+            var argumentValue = EscapeGraphQlStringValue(Convert.ToString(value, CultureInfo.InvariantCulture));
             return $"\"{argumentValue}\"";
         }
 

diff --git a/...or.Test/ExpectedSingleFileGenerationContext/SourceGeneratorResultWithFileScopedNamespaces b/...or.Test/ExpectedSingleFileGenerationContext/SourceGeneratorResultWithFileScopedNamespaces
@@ -213,7 +213,7 @@ internal static class GraphQlQueryHelper
         if (value is short || value is ushort || value is byte || value is int || value is uint || value is long || value is ulong || value is float || value is double || value is decimal)
             return Convert.ToString(value, CultureInfo.InvariantCulture);
 
-        var argumentValue = Convert.ToString(value, CultureInfo.InvariantCulture);
+        var argumentValue = EscapeGraphQlStringValue(Convert.ToString(value, CultureInfo.InvariantCulture));
         return $"\"{argumentValue}\"";
     }