Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add number.ToWords() support for large numbers in French #989

Merged
merged 1 commit into from
May 15, 2021

Conversation

louis-z
Copy link
Contributor

@louis-z louis-z commented Oct 2, 2020

Fixes #988

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@louis-z louis-z force-pushed the issue-988 branch 2 times, most recently from dbd2805 to 01c4768 Compare October 7, 2020 23:35
@louis-z louis-z changed the title Add support for large numbers in French up to 10^18 level Add number.ToWords() support for large numbers in French Oct 11, 2020
@louis-z louis-z force-pushed the issue-988 branch 2 times, most recently from 8ad1b71 to 8354a5c Compare November 12, 2020 00:22
@louis-z louis-z force-pushed the issue-988 branch 2 times, most recently from 490fbcc to afb2e26 Compare May 3, 2021 20:45
@clairernovotny
Copy link
Member

Can we do this without a breaking change? New overloads are fine, but renaming existing methods will break people.

@louis-z
Copy link
Contributor Author

louis-z commented May 3, 2021

Can we do this without a breaking change? New overloads are fine, but renaming existing methods will break people.

Absolutely. I will adapt the PR accordingly.

@louis-z
Copy link
Contributor Author

louis-z commented May 3, 2021

Actually the modified classes are internal. Do you still want me to prevent API breakage?

Note that French uses the "long scale" rather than the "short scale" for large numbers.
@hazzik hazzik merged commit b8e254d into Humanizr:main May 15, 2021
@louis-z louis-z deleted the issue-988 branch May 15, 2021 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

number.ToWords() should support large numbers in French
3 participants