Detailed time span #65
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
MehdiK
commented
Jan 22, 2014
MehdiK
commented
- Cleaned up TimeSpan Humanize tests
- Added precision to TimeSpan Humanize. This addresses TimeSpan's should show the time breakdown #29 Question: 11 days seems to output 1 week, is this the designed behaviour? #56
- Updated ApiApprover specs - oops
|
I'd really appreciate a code review and feedback |
| CouldBeEither, | ||
| Plural, | ||
| Singular, | ||
| value__, |
There was a problem hiding this comment.
I saw that too. It looks like a bug in ApiApprover for enums. I will check out ApiApprover to see if I can find and fix it.
|
Looks great mate!! Nice work as always. |
This was referenced Jan 23, 2014
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.