Add ToOrdinalWords extension with gender overload #500
Conversation
| { | ||
| var date = new DateTime(2015, 1, 1); | ||
|
|
||
| Assert.Equal("1º janeiro 2015", date.ToOrdinalWords(GrammaticalGender.Masculine)); |
There was a problem hiding this comment.
@hazzik what do you target with this question, the gender parameter?
I also thought it should be tied to a default value, the Ordinalize extensions also do it that way. By this the localization can decide which gender to pick as default.
There was a problem hiding this comment.
It's about the question on the main thread. For example, in russian the gender of the number in a date is always neutral (средний род), and for some languages it can be different. I don't think that we need this method overload at all.
But, for russian we need an overload with grammatical case, to say "1-го апреля 2016" (at 1st April 2015), for example.
|
In portugise, on what the gender of a number is based? Month? Year? Number itself? Or some other word? |
| /// <returns>The date in ordinal words</returns> | ||
| public static string ToOrdinalWords(this DateTime input) | ||
| { | ||
| return input.Day.Ordinalize() + input.ToString(" MMMM yyyy"); |
There was a problem hiding this comment.
I wonder whether it works for all locales?
How do Americans write such dates? Wasn't it January 1st 2015?
There was a problem hiding this comment.
Yes, sure, this is language specific.
There was a problem hiding this comment.
Good point, there are plenty of countries that do MMDDYY and plenty that do YYMMDD. I'm working on an update to be localised. Can I ask if I just put up a PR request with only a couple of languages is that ok? Others could then add more in other languages?
There was a problem hiding this comment.
Yes, just provide as minimum the implementation for English, other languages can then localize this functionality with own PRs. See for example #493
|
Please also extend the |
|
Should the readme.md use en-GB or en-US as default examples? Or just both? |
|
@RobPethick please lean on number to ordinal words section. |
|
@mexx thanks but I think in that case en-GB and en-US are the same? And in my case they are different ( 1st January 2015 vs January 1st, 2015) |
|
I don't get your point, the documentation should show that this functionality is available. An example in either locale would be sufficient. |
|
@mexx Thanks! I was just checking there wasn't an existing convention to adhere to. |
|
@RobPethick Just a head's up that it'd be great to resolve this in the next couple of weeks if you'd like to get this into 2.0. I'll leave it to @mexx as to when it's ready. |
| @@ -263,4 +264,4 @@ | |||
| <Target Name="AfterBuild"> | |||
| </Target> | |||
| --> | |||
| </Project> | |||
| </Project> | |||
There was a problem hiding this comment.
changes to this file should be reverted, as they only formatting and add no value to the feature.
|
Tagging as vNext as the same thing as @hazzik mentioned for
|
…tion and add readme section
|
@RobPethick @mexx is this ready to go once the conflicts are resolved? As to support for the other languages, I don't think we need to hold this up -- we can always release again once more languages are added. |
|
rebased and merged here 3d71fd9, thanks! |
Fixes #328