Default collection formatter not throwing exception

[ghost]

Regarding issue #392, this implementation of the default collection formatter now does not throw an exception. In my opinion, it is not a good solution to throw an exception in default implementation because this throws an exception on an not supporter language (I had this with German and Danish).

[hazzik]

You can use something like:

using(new AmbientCulture("es")) {
    // test
}

[justin-edwards]

I don't believe this will handle Cyrillic languages, Asian langues, Arabic, or Greek correctly. There may be others I can't think of at the moment as well.

Edit for clarity: I don't know that's enough to prevent going forward with this, just mentioning it.

[hazzik]

@justin-edwards what's wrong with Cyrillic languages?

[hazzik]

I think DefaultCollectionFormatter should return string without any additional separator, just string.Join(", ", items);

[justin-edwards]

@hazzik, sorry, I had intended to remove Cyrillic languages from that list after I researched it. I may have had bad info on Greek as well (I spoke with someone fluent, but further research contradicts what they said).

[hazzik]

@MehdiK, @mexx what'd you say?

[mexx]

@hazzik I find the idea of & a little better as ,. We already have other areas where the default going to some English inspired implementation. So I'm OK with &.

For me default implementation should produce following output:

new[] { "a", "b" }.Humanize() = "a & b"
new[] { "a", "b", "c", "d" }.Humanize() = "a, b, c & d"

[MehdiK]

I'm with @mexx on this. Also regardless of the default, if one is interested in a better formatter they should just provide their separators in the config.

[MehdiK]

I resolved the raised issues, rebased and pushed the code. Thanks.

[MehdiK]

This is now released to NuGet as v1.35.0. Thanks for the quick fix.