Fixes #263 Add huminization of collections #268
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| "A Third String", | ||
| }; | ||
|
|
||
| Assert.Equal("A String, Another String, or A Third String", collection.Humanize("or")); |
|
Thanks. It's very well done. Just a few comments I left on the code. I also need to check it out in VS. Will try to do tomorrow. |
|
|
||
| string formatString = count > 2 ? "{0}, {1} {2}" : "{0} {1} {2}"; | ||
|
|
||
| separator = separator.Trim(); |
There was a problem hiding this comment.
why is it necessary to trim the provided separator?
Currently there is no test for this line, it could be removed without breaking any present tests.
There was a problem hiding this comment.
I'd agree, removed in justin-edwards@27583dd
|
|
||
| public virtual string Humanize<T>(IEnumerable<T> collection, Func<T, String> objectFormatter, String separator) | ||
| { | ||
| throw new NotImplementedException("A collection formatter for the current culture has not been implemented yet."); |
|
Cool. This is rebased and pushed now (because you were a few commits behind). Thanks. |
|
Oh!! I merged and released this and then realized you haven't added the readme entry for it!! Do'h. Can you add the entries please? Soon? :p |
|
I'm working on the readme right now. |
|
Cool. Please send it on a separate PR based on top of the latest. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not ready for merge yet, but I was hoping for a little code review before I went through and documented.
I think it would be useful to have some way to register a default that wasn't
ToString()for specific types, though I'm not sure what I'd call it or where that should live or if this PR needs to wait on that feature.