-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add french localisation for NumberToWords #190
Conversation
Added french (fr-FR) localisation & tests for NumberToWords Localized NumberToOrdinalWordsExtension, NumberToOrdinalWordsTests and DateTimeHumanizePrecisionStrategyTests
I hope I did it right this time ^^ |
Are the "newer" forms (septante, nonante) used elsewhere, say in Belgium or Canada? Might we need a region check within the ToWords methods to account for these situations? I don't think they warrant a completely separate translation. |
@Tradioyes also, would you feel comfortable adding those? Should someone from those regions localize the items mentioned? |
Septante and nonante are both used in fr-BE and fr-CH, octante is fr-CH only I think. These are not the newer forms, but country-specific. |
I just discovered that octante is belgian while huitante is swiss. Someone more comfortable than me with those variations should definitely do it ^^ |
In my brief study of French I was thrown by the counting after you get to soixante, I knew there were more Anglicized versions of seventy and such, but wow, regional differences, no wonder there are hundreds of ISO language codes. |
Great, thanks! |
This is now published to NuGet as v1.21.1. Thanks. |
DateTimeHumanizePrecisionStrategyTests