Added Bulgarian localization, date and timespan tests #181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank god, a PR with no review comments!! Thanks for the clean consistent code and tests. Please rebase your code on top of the upstream, add your PR to the release notes and force push. |
This reverts commit 18c51a1.
Similar classes exist in System.Web.ModelBinding, which aren't used by ASP.Net MVC. Users copying and pasting the sample from the readme might end up using the wrong namespace.
…d of a separate extension
|
Thank you! It is great to work on this wonderful library. I'll start implementing the NumberToWords functionality. |
|
I cherry-picked your commit as your rebase had gone bad and your commits were far behind the head. For future contribution please follow the contribution guideline. Thanks for the work and I am glad you liked the experience. |
Closed
|
This is now published to NuGet as v1.21.1. Thanks. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Bulgarian localization, date and timespan tests.