remove GitVersioning #1407
Merged
remove GitVersioning #1407
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, please reverse this---lets chat if you have questions. |
|
@clairernovotny would love to chat. ping me at [email protected] to set up a call |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i propose we move off GitVersion. for context i am one of the original creators of GitVersion. and i no longer use it in any of my projects, nor recommend it to others. GitVersion predates the the simplified versioning of the new sdk style projects. ie now we can have a single version number that is applied to nugets, assembly versions and metadata. and when GitVersion fails, due to some git tree structure it doesnt understand, it is very difficult to debug.
GitVersion is also cognitive load for contributors/maintainers since it is a different approach from the standard "version in msbuild file" approach