Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Localisation of Tupleize method & Add Turkish support #1094

Merged
merged 3 commits into from
Jul 3, 2021

Conversation

hakanoo
Copy link
Contributor

@hakanoo hakanoo commented Jun 22, 2021

Tupleize method works only for English. In order to use it for other languages the method has been moved to INumberToWordsConverter as string ConvertToTuple(int number). And Turkish language support added.

Here is a checklist you should tick through before submitting a pull request:

  • Implementation is clean
  • Code adheres to the existing coding standards; e.g. no curlies for one-line blocks, no redundant empty lines between methods or code blocks, spaces rather than tabs, etc.
  • No Code Analysis warnings
  • There is proper unit test coverage
  • If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attribution
  • There are very few or no comments (because comments shouldn't be needed if you write clean code)
  • Xml documentation is added/updated for the addition/change
  • Your PR is (re)based on top of the latest commits from the dev branch (more info below)
  • Link to the issue(s) you're fixing from your PR description. Use fixes #<the issue number>
  • Readme is updated if you change an existing feature or add a new one
  • Run either build.cmd or build.ps1 and ensure there are no test failures

@dnfadmin
Copy link

dnfadmin commented Jun 22, 2021

CLA assistant check
All CLA requirements met.

@hakanoo hakanoo force-pushed the LocalizeTupleMethod branch from c580ff5 to 03560ba Compare June 23, 2021 09:59
@hakanoo hakanoo changed the title Localize tuple method Localisation of Tupleize method & Add Turkish support Jun 23, 2021
@clairernovotny clairernovotny merged commit c17c86b into Humanizr:main Jul 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants