Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add try/catch around formatter registration #1065

Merged
merged 1 commit into from
May 5, 2021
Merged

Add try/catch around formatter registration #1065

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 11 additions & 2 deletions src/Humanizer/Configuration/FormatterRegistry.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,4 +1,6 @@
using Humanizer.Localisation.Formatters;
using System.Globalization;

using Humanizer.Localisation.Formatters;

namespace Humanizer.Configuration
{
Expand Down Expand Up @@ -56,7 +58,14 @@ public FormatterRegistry() : base(new DefaultFormatter("en-US"))

private void RegisterDefaultFormatter(string localeCode)
{
Register(localeCode, new DefaultFormatter(localeCode));
try
{
Register(localeCode, new DefaultFormatter(localeCode));
}
catch (CultureNotFoundException)
{
// Some OS's may not support the particular culture. Not much we can do for those.
}
}

private void RegisterCzechSlovakPolishFormatter(string localeCode)
Expand Down