Transform with Culture via ICulturedStringTransformer
#1063
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As proposed in #1061 (comment):
input.Transform(culture, transformers)
ICulturedStringTransformer : IStringTransformer
Humanizer/src/Humanizer/Transformer/ICulturedStringTransformer.cs
Line 16 in 3e23bb4
IStringTransformer.Transform()
to acceptculture
. Trivial for custom implementations to be updated with the new parameter, since they can just ignoreculture
if they don't care.To.LowerCase
and such to returnICulturedStringTransformer
(shouldn't be a breaking change, since it's assignable toIStringTransformer
, with internal classes updated to implement the new overload.Checklist
Here is a checklist you should tick through before submitting a pull request:
If the code is copied from StackOverflow (or a blog or OSS) full disclosure is included. That includes required license files and/or file headers explaining where the code came from with proper attributiondev
branch (more info below)fixes #<the issue number>
Readme is updated if you change an existing feature or add a new onebuild.cmd
orbuild.ps1
and ensure there are no test failures