Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compilation fails on the very latest Visual Studios due to character-encoding problem #1245

Closed
vilinet opened this issue Dec 12, 2022 · 1 comment
Closed

Compilation fails on the very latest Visual Studios due to character-encoding problem #1245

vilinet opened this issue Dec 12, 2022 · 1 comment

Comments

@vilinet
Copy link
Contributor

vilinet commented Dec 12, 2022

We have found this issue when using the latest VS: dotnet/android#7447
And one of the issue the xamarin team found that there is a strange char in the code:

Humanizer/src/Humanizer/Localisation/NumberToWords/GreekNumberToWordsConverter.cs

Line 187 in 7f80e03

private string ConvertIntΒ13(long number, bool returnPluralized)

That "B" char i think is being the Greek Beta char, and we were told to fix that as it is being somehow a not liked char by the compiler.
vilinet added a commit to vilinet/Humanizer that referenced this issue Dec 12, 2022
@vilinet
Humanizr#1245: Replace the greek (B) "Beta" char to a regular B in me…
a6994b8 
…thods as very latest visual studio is more sensitive somehow to character encodings
@vilinet vilinet mentioned this issue Dec 12, 2022
Merged
SimonCropp pushed a commit that referenced this issue Feb 12, 2024
@vilinet
#1245: Replace the greek (B) "Beta" char to a regular B in methods as…
7491330 
… very latest visual studio is more sensitive somehow to character encodings (#1246)
@SimonCropp
Copy link
Collaborator

Pr mereged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@SimonCropp @vilinet