Various developer improvements #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
??? |
|
@farioas please, review it. |
farioas
reviewed
Sep 20, 2021
farioas
reviewed
Sep 20, 2021
farioas
reviewed
Sep 20, 2021
farioas
reviewed
Sep 20, 2021
farioas
requested changes
Sep 20, 2021
|
The devcontainer is the most important change in this PR to me as it enables codespaces/devcontainers. As stated in the original message: feel free to cherry pick 😄 |
|
If the devcontainer is the only thing you'd like to merge, it's probably easier to create a new PR with just this change, right? |
|
I'd recommend to adjust the existing pull-request, since we already have a lot of abandoned pull-requests 😄 |
|
@farioas might have butchered the commit history a bit while trying to rebase and merge. Please use squash. |
farioas
approved these changes
Sep 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Started to fix #633, but I noticed, that I misunderstood something: since ADLS2 is based on blob containers, the current interface works just fine with ADLS2 storage for accessing files.
But as I started setting up the dev environment before actually checking the function, I still have some code to contribute.
I think, some people might find VS Code Devcontainers useful for developing further features without huge struggles to setup the dev env. Feel free to cherry pick.