Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: OPTIC-1356: Remove Stale Feature Flag #6690

Conversation

mcanu
Copy link
Contributor

@mcanu mcanu commented Nov 20, 2024

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

Cleaning up stale feature flag fflag-feat-front-dev-2982-label-weights-settings, stale since July. Has LSE changes.

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit 9c545da
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/673e004f0c6f730008b7dbc3

Copy link

netlify bot commented Nov 20, 2024

Deploy Preview for heartex-docs failed. Why did it fail? →

Name Link
🔨 Latest commit 9c545da
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/673e004f8a1a490008b708a4

Copy link

codecov bot commented Nov 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.77%. Comparing base (e4434bc) to head (9c545da).
Report is 3 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #6690   +/-   ##
========================================
  Coverage    76.77%   76.77%           
========================================
  Files          170      170           
  Lines        13883    13883           
========================================
+ Hits         10658    10659    +1     
+ Misses        3225     3224    -1     
Flag Coverage Δ
pytests 76.77% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

@mcanu mcanu force-pushed the fb-optic-1356/remove-stale-feature-flag---fflag-feat-front-dev-2982-label-weights-settings branch from f7f2835 to 9c545da Compare November 20, 2024 15:29
@mcanu mcanu merged commit 2142c03 into develop Nov 20, 2024
39 of 43 checks passed
fredheir pushed a commit to ResetNetwork/label-studio that referenced this pull request Jan 1, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants