-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LEAP-1151: Show region indices on regions #6103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Display region index from Outliner on regions itself, so it will help to find regions visually. Index is stored in region and updated every time the order changes (new region added, order direction is changed)
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
nick-skriabin
approved these changes
Jul 17, 2024
Gondragos
reviewed
Jul 17, 2024
Gondragos
approved these changes
Jul 17, 2024
MihajloHoma
approved these changes
Jul 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Display region index from Outliner on regions itself, so it will help to find regions visually.
Index is stored in region and updated every time the order changes (new region added, order direction is changed)
PR fulfills these requirements
Change has impacts in these area(s)
Describe the reason for change
With lot of regions and/or with overlapping regions it's hard to select exact region you need. This fix adds region indices from regions tree, so you can select the region you need precisely in regions tree, without interaction with image, just by looking for the number.
Does this change affect performance?
It writes
region_index
on every regions tree change, but that's a volatile property + it's updated only if index is changed, so should be a very small effect.Does this PR introduce a breaking change?
What level of testing was included in the change?