Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1151: Show region indices on regions #6103

Merged
merged 6 commits into from
Jul 19, 2024

Conversation

hlomzik
Copy link
Collaborator

@hlomzik hlomzik commented Jul 16, 2024

Display region index from Outliner on regions itself, so it will help to find regions visually.
Index is stored in region and updated every time the order changes (new region added, order direction is changed)

PR fulfills these requirements

  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

With lot of regions and/or with overlapping regions it's hard to select exact region you need. This fix adds region indices from regions tree, so you can select the region you need precisely in regions tree, without interaction with image, just by looking for the number.

Does this change affect performance?

It writes region_index on every regions tree change, but that's a volatile property + it's updated only if index is changed, so should be a very small effect.

Does this PR introduce a breaking change?

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

  • e2e
  • integration
  • unit

Display region index from Outliner on regions itself,
so it will help to find regions visually.
Index is stored in region and updated every time the order changes
(new region added, order direction is changed)
@github-actions github-actions bot added the feat label Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit f6f8953
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66985ed8554a470008e3d9da

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit f6f8953
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66985ed8ff7acf0008777b5b

@hlomzik hlomzik merged commit 40a62f6 into develop Jul 19, 2024
31 checks passed
@hlomzik hlomzik deleted the fb-leap-1151/region-numbers branch July 19, 2024 15:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants