Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: LEAP-1198: Add labeling unsaved changes warning #6100

Merged
merged 14 commits into from
Aug 1, 2024

Conversation

Gondragos
Copy link
Collaborator

@Gondragos Gondragos commented Jul 16, 2024

This introduces a functionality of blocking any navigation while there are some unsaved changes in the labeling config.
image
It provides:

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Does this change affect security?

I do not think so.

What feature flags were used to cover this change?

fflag_feat_front_leap_1198_unsaved_changes_180724

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

I've tried to avoid breaking changes. But we will see...

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

Labeling Config, ApiProvider, ProjectProvider, BrowserHistory

@github-actions github-actions bot added the feat label Jul 16, 2024
Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit abd203f
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/66aafbe7ede5180008f52498

Copy link

netlify bot commented Jul 16, 2024

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit abd203f
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/66aafbe7ee782800081cc849

Copy link
Contributor

@yyassi-heartex yyassi-heartex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good overall - my only request would be to add unit tests for the new component

# Conflicts:
#	label_studio/feature_flags.json
#	web/apps/labelstudio/src/pages/CreateProject/Config/Config.jsx
@Gondragos
Copy link
Collaborator Author

Gondragos commented Jul 30, 2024

/git merge develop

Workflow run
Successfully merged: 17 files changed, 28 insertions(+), 632 deletions(-)

@Gondragos Gondragos merged commit 58c0833 into develop Aug 1, 2024
31 checks passed
@Gondragos Gondragos deleted the fb-leap-1198/unsaved-change branch August 1, 2024 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants