-
Notifications
You must be signed in to change notification settings - Fork 2.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: LEAP-1198: Add labeling unsaved changes warning #6100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
✅ Deploy Preview for heartex-docs canceled.
|
yyassi-heartex
approved these changes
Jul 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good overall - my only request would be to add unit tests for the new component
hlomzik
reviewed
Jul 23, 2024
hlomzik
reviewed
Jul 23, 2024
hlomzik
reviewed
Jul 23, 2024
# Conflicts: # label_studio/feature_flags.json # web/apps/labelstudio/src/pages/CreateProject/Config/Config.jsx
bmartel
approved these changes
Jul 29, 2024
/git merge develop
|
bmartel
approved these changes
Aug 1, 2024
MihajloHoma
approved these changes
Aug 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a functionality of blocking any navigation while there are some unsaved changes in the labeling config.
It provides:
LeaveBlocker
that manages blocking of all cases of navigationUnsavedChanges
that usesLeaveBlocker
and provides a modalunsavedChangesModal
for action confirmation dialogbrowserHistory
improvement to handle history blocks from LeaveBlocker and indicate right that it is blockingpopstate
at AsyncPage.js for preventing false positive triggering while history is blockedApiProvider
including it's typesupdateProject
to return errors to handle them in editorPR fulfills these requirements
[fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made
ex.fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
Change has impacts in these area(s)
Does this change affect security?
I do not think so.
What feature flags were used to cover this change?
fflag_feat_front_leap_1198_unsaved_changes_180724
Does this PR introduce a breaking change?
(check only one)
I've tried to avoid breaking changes. But we will see...
What level of testing was included in the change?
(check all that apply)
Which logical domain(s) does this change affect?
Labeling Config
,ApiProvider
,ProjectProvider
,BrowserHistory