-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: LEAP-859: Fix data manager breaking on displaying specific data #5692
Conversation
The commit replaces usage of 'toStudlyCaps' across several files with a new function 'normalizeCellAlias' to standardize cell alias normalization across the app. This change ensures a consistent approach to handling cell alias normalization.
✅ Deploy Preview for heartex-docs canceled.
|
✅ Deploy Preview for label-studio-docs-new-theme canceled.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with just a few minor adjustments needed to improve readability but not a blocket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also that would be nice if we had some tests here
Co-authored-by: Julio Sgarbi <[email protected]>
Co-authored-by: yyassi-heartex <[email protected]>
/git merge develop
|
The commit replaces usage of
toStudlyCaps
across several files with a new functionnormalizeCellAlias
to standardize cell alias normalization across the app. This change ensures a consistent approach to handling cell alias normalization.CellViews
is used only to chose the right way do display the column and for aliases there are just a couple of variants that are apllicable in that case. So that changing any other string will not break anything.PR fulfills these requirements
Describe the reason for change
toStudlyCaps
includes codewhich does not work with values like
"smthng_"
aschr
should be a string but we getundefined
. To prevent this we need to remove unsafe trailing special characters before using this function.This change affects (describe how if yes)
Does this PR introduce a breaking change?
What level of testing was included in the change?
Which logical domain(s) does this change affect?
CellViews