Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: DIA-783: Fix adding candidate task if it was accidentally deleted from project #5222

Merged
merged 4 commits into from
Dec 28, 2023

Conversation

KonstantinKorotaev
Copy link
Contributor

PR fulfills these requirements

  • Commit message(s) and PR title follows the format [fix|feat|ci|chore|doc]: TICKET-ID: Short description of change made ex. fix: DEV-XXXX: Removed inconsistent code usage causing intermittent errors
  • Tests for the changes have been added/updated (for bug fixes/features)
  • Docs have been added/updated (for bug fixes/features)
  • Best efforts were made to ensure docs/code are concise and coherent (checked for spelling/grammatical errors, commented out code, debug logs etc.)
  • Self-reviewed and ran all changes on a local instance (for bug fixes/features)

Change has impacts in these area(s)

(check all that apply)

  • Product design
  • Backend (Database)
  • Backend (API)
  • Frontend

Describe the reason for change

(link to issue, supportive screenshots etc.)
Fix adding candidate task if it was accidentally deleted from project

What does this fix?

(if this is a bug fix)
Fix adding candidate task if it was accidentally deleted from project

What is the new behavior?

(if this is a breaking or feature change)
Add candidate task if it was accidentally deleted from project

What is the current behavior?

(if this is a breaking or feature change)
Record exported to project (from dataset) can not be re-added if it was accidentally deleted from the project

What libraries were added/updated?

(list all with version changes)
No

Does this change affect performance?

(if so describe the impacts positive or negative)
No

Does this change affect security?

(if so describe the impacts positive or negative)
No

What alternative approaches were there?

(briefly list any if applicable)
No

What feature flags were used to cover this change?

(briefly list any if applicable)
No

Does this PR introduce a breaking change?

(check only one)

  • Yes, and covered entirely by feature flag(s)
  • Yes, and covered partially by feature flag(s)
  • No
  • Not sure (briefly explain the situation below)

What level of testing was included in the change?

(check all that apply)

  • e2e
  • integration
  • unit

Which logical domain(s) does this change affect?

(for bug fixes/features, be as precise as possible. ex. Authentication, Annotation History, Review Stream etc.)
Datasets

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for label-studio-docs-new-theme canceled.

Name Link
🔨 Latest commit ca53057
🔍 Latest deploy log https://app.netlify.com/sites/label-studio-docs-new-theme/deploys/65896799fd52fe00081172e6

Copy link

netlify bot commented Dec 22, 2023

Deploy Preview for heartex-docs canceled.

Name Link
🔨 Latest commit ca53057
🔍 Latest deploy log https://app.netlify.com/sites/heartex-docs/deploys/6589679953524900080972b5

@github-actions github-actions bot added the fix label Dec 22, 2023
Copy link

codecov bot commented Dec 22, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0962453) 76.11% compared to head (ca53057) 76.13%.
Report is 8 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #5222      +/-   ##
===========================================
+ Coverage    76.11%   76.13%   +0.01%     
===========================================
  Files          154      154              
  Lines        12818    12828      +10     
===========================================
+ Hits          9757     9767      +10     
  Misses        3061     3061              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KonstantinKorotaev KonstantinKorotaev merged commit 2e3106d into develop Dec 28, 2023
35 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants