-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use public inputs in example files #84
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me!
ccdd899
to
ebb72e0
Compare
"gs://broad-dsde-mint-dev-teststorage/10x/demo/fastqs/pbmc8k_S1_L007_R1_001.fastq.gz", | ||
"gs://broad-dsde-mint-dev-teststorage/10x/demo/fastqs/pbmc8k_S1_L007_R2_001.fastq.gz", | ||
"gs://broad-dsde-mint-dev-teststorage/10x/demo/fastqs/pbmc8k_S1_L007_I1_001.fastq.gz" | ||
"gs://hca-dcp-mint-test-data/10x/demo/fastqs/pbmc8k_S1_L007_R1_001.fastq.gz", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The inputs for optimus have changed so there are now three different arrays for fastq files instead of an array of arrays: https://github.com/HumanCellAtlas/skylab/blob/master/pipelines/optimus/Optimus.wdl#L16
I just noticed this after looking at Marcus's PR that changes the test inputs file: https://github.com/HumanCellAtlas/skylab/pull/86/files#diff-c53d14ec9a922a0786f2647a9480b7b3R6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Confirmed, could you please fix my screw-up and update this to be:
"Optimus.r1": [
"gs://hca-dcp-mint-test-data/10x/demo/fastqs/pbmc8k_S1_L007_R1_001.fastq.gz",
"gs://hca-dcp-mint-test-data/10x/demo/fastqs/pbmc8k_S1_L007_R1_001.fastq.gz"
],
"Optimus.r2": [
"gs://hca-dcp-mint-test-data/10x/demo/fastqs/pbmc8k_S1_L007_R2_001.fastq.gz",
"gs://hca-dcp-mint-test-data/10x/demo/fastqs/pbmc8k_S1_L007_R2_001.fastq.gz"
],
"Optimus.i1": [
"gs://hca-dcp-mint-test-data/10x/demo/fastqs/pbmc8k_S1_L007_I1_001.fastq.gz",
"gs://hca-dcp-mint-test-data/10x/demo/fastqs/pbmc8k_S1_L007_I1_001.fastq.gz"
]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ambrosejcarr should this be data from the 10x or Optimus folder here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
10x is the data type, so is appropriate here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, I fixed that, could use another look @ambrosejcarr.
@@ -2,23 +2,23 @@ | |||
"outputs": { | |||
"Optimus.tag_gene_exon_log": [ | |||
[ | |||
"gs://broad-dsde-mint-dev-cromwell-execution/cromwell-executions/Optimus/c98322d7-406d-4e3f-96c8-e2bd1429e645/call-AlignTagCorrectUmis/shard-0/AlignTagCorrectUmis/d250b98d-a2f0-4b19-be86-e347bd076a5f/call-TagGeneExon/shard-0/gene_exon_tag_summary.log" | |||
"gs://hca-dcp-mint-test-data/10x/demo/cromwell-executions/Optimus/c98322d7-406d-4e3f-96c8-e2bd1429e645/call-AlignTagCorrectUmis/shard-0/AlignTagCorrectUmis/d250b98d-a2f0-4b19-be86-e347bd076a5f/call-TagGeneExon/shard-0/gene_exon_tag_summary.log" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess this is fine to do find/replace, but in the example that was given, they point to real files that a mint dev could inspect, whereas the changed files don't exist.
Other opinions on this @samanehsan? I guess for public users the existence of these files is a bit pointless since they can't access them anyway (unless we moved them the hca-dcp-mint-test-data
bucket
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually copied over those output files to the public bucket. Are you sure they're not there? I may have missed some or given the wrong paths here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops, my fault! Sorry. You're right.
This looks good to me. One comment that does not directly relate to this, is that I would prefer we didn't propagate the disorganization from the other bucket. These are all human, and should have been generated from the GRCh38_Gencode files:
If accurate, lets move them into Second, we should eventually remove the below index and replace it with GRCh38, since we're going to use GENCODE.
|
Yes, we can move these annotation files into one folder. As for the kco reference bundle, we probably won't use them any more. it is okay to remove from our system. |
jenkins retest |
… into GRCh38_Gencode folder. (539)
23d4f57
to
2ec3cfb
Compare
Previously, the example inputs files were pointing to a private bucket in our dev project. This PR changes them to point to inputs in a public bucket instead.
See:
https://elastc.com/c/QN-0A7Mr/539-remove-environment-specific-params-from-example-inputs
Related PR: HumanCellAtlas/pipeline-tools#18