Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: validate command args and set log formatter on fatal error #122

Merged
merged 3 commits into from
Aug 17, 2023
Merged

fix: validate command args and set log formatter on fatal error #122

merged 3 commits into from
Aug 17, 2023

Conversation

shreyasbhat0
Copy link
Contributor

Description:

Commit Message

fix: validate command args and set log formatter on fatal error

see the guidelines for commit messages.

Changelog Entry

version: command arguments validation and logger formatting

Checklist:

  • I have performed a self-review of my own code
  • I have documented my code in accordance with the documentation guidelines
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have run the unit tests
  • I only have one commit (if not, squash them into one commit).
  • I have a descriptive commit message that adheres to the commit message guidelines

Please review the CONTRIBUTING.md file for detailed contributing guidelines.

@shreyasbhat0 shreyasbhat0 added the test:smoke PR with this labels will run the smoke test script label Aug 17, 2023
@shreyasbhat0 shreyasbhat0 self-assigned this Aug 17, 2023
@hemz10 hemz10 merged commit a8d67ee into main Aug 17, 2023
@hemz10 hemz10 deleted the fix/handle-invalid-input-for-bridge-command branch August 17, 2023 11:44
shreyasbhat0 added a commit that referenced this pull request Jan 24, 2024
@shreyasbhat0
fix: validate command args and set log formatter on fatal error (#122)
fec1173 
* fix: set proper  log formatter when fatal error

* fix: validate command when invalid args are given
Mr-Nobody21 pushed a commit to Mr-Nobody21/DIVE that referenced this pull request May 7, 2024
@shreyasbhat0
fix: validate command args and set log formatter on fatal error (Hugo…
247d5c2 
…Byte#122)

* fix: set proper  log formatter when fatal error

* fix: validate command when invalid args are given
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hemz10 hemz10 hemz10 approved these changes

@Mr-Nobody21 Mr-Nobody21 Awaiting requested review from Mr-Nobody21

Assignees

@shreyasbhat0 shreyasbhat0

Labels
test:smoke PR with this labels will run the smoke test script
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@shreyasbhat0 @hemz10