Fix Shortcode context for v2 blocks #2919
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Shortcodes in the new block system do not get access to the correct
.Page
variable (see #2918 ). The problem is the use ofmarkdownify
function to parse$block.content.text
, since it actually is an alias tosite.Home.RenderString
since v 0.93.0 (see gohugoio/hugo#9959 (comment)).This causes the shortcodes to always get the Homepage as
.Page
variable. The fix is to substitutemarkdownify
with$page.RenderString
, which gives the correct context.An actual example of this behaviour can be found in this branch (in the
csv
page):This PR fixes #2918.