Fix table class name in fixHugoOutput #2897
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
addClass must be called with class name only instead of '.table' as class name
✅ Deploy Preview for hugo-portfolio-theme canceled.
|
✅ Deploy Preview for markdown-slides canceled.
|
gcushen
changed the title
gcushen
approved these changes
Dec 27, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
The addClass call must be called with class name only instead of '.table' as class name.
Previously this lead to undesirable behavior because markdown tables would be rendered without the proper CSS classes (see screenshots below).
Since I only noticed this problem just now, I did not create an issue so far.
Screenshots
Old behavior:
New behavior: