Skip to content
This repository has been archived by the owner on Dec 8, 2022. It is now read-only.

Status bar refactoring and other minor changes #104

Merged
merged 3 commits into from
May 14, 2021
Merged

Status bar refactoring and other minor changes #104

merged 3 commits into from
May 14, 2021

Conversation

AndreLaranjeira
Copy link
Collaborator

Description

  • Status bar coloring now uses useFocusEffect, which is triggered when the user goes back to a previous page;
  • Changed color of status bar in 1 page to match theme template;
  • Minor changes to header icons used and icon behavior;
  • Changed the navigation reset applied when a pet is transferred;
  • Minor code and comments refactoring;

Motivation and Context

Closes #41.

How has this been tested?

My cellphone;

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.

@AndreLaranjeira
Refactored status bar and other minor details
0bdd2f6 
* Status bar color effect is now done via useFocusEffect, allowing 
status bar to be re-colored when the user goes back in the navigation 
stack;
* Minor refactoring of code;
* Changed the color of status bar in Interested page;
* Changed some comments;
@AndreLaranjeira
Minor changes to pages and layout behavior
b3c8753 
* Search icon now does nothing when clicked on instead of going back to 
the last page;
* When a pet is given up for adoption, the user now returns to the my 
pets page instead of being redirected back home;
* My pets page now has the right header icons;
@AndreLaranjeira AndreLaranjeira requested a review from Hugo-NF May 8, 2021 19:22
@Hugo-NF Hugo-NF merged commit 4fe17e8 into development May 14, 2021
@Hugo-NF Hugo-NF deleted the 041_status_bar_refactor branch May 14, 2021 01:33
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@Hugo-NF Hugo-NF Hugo-NF approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AndreLaranjeira @Hugo-NF