Skip to content

Commit

Permalink
Fix for open Issue 80 in update_datasource_connection and update_work…
Browse files Browse the repository at this point in the history
…book_connection
  • Loading branch information
Bryant Howell committed Feb 17, 2020
1 parent df5685e commit 4235b2a
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion tableau_rest_api/methods/datasource.py
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,7 @@ def update_datasource_connection_by_luid(self, datasource_luid: str, new_server_
new_connection_username: Optional[str] = None,
new_connection_password: Optional[str] = None) -> ET.Element:
self.start_log_block()
tsr = self.__build_connection_update_xml(new_server_address, new_server_port,
tsr = self.rest_api_base.__build_connection_update_xml(new_server_address, new_server_port,
new_connection_username,
new_connection_password)
url = self.build_api_url("datasources/{}/connection".format(datasource_luid))
Expand Down
2 changes: 1 addition & 1 deletion tableau_rest_api/methods/workbook.py
Original file line number Diff line number Diff line change
Expand Up @@ -166,7 +166,7 @@ def update_workbook_connection_by_luid(self, wb_luid: str, connection_luid: str,
new_connection_username: Optional[str] = None,
new_connection_password: Optional[str] = None) -> ET.Element:
self.start_log_block()
tsr = self.__build_connection_update_xml(new_server_address, new_server_port, new_connection_username,
tsr = self.rest_api_base.__build_connection_update_xml(new_server_address, new_server_port, new_connection_username,
new_connection_password)
url = self.build_api_url("workbooks/{}/connections/{}".format(wb_luid, connection_luid))
response = self.send_update_request(url, tsr)
Expand Down

0 comments on commit 4235b2a

Please sign in to comment.