Support Attachment upon link unfurling #287
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The model for unfurling messages was recently updated to match the latest changes in Slack (using Block Kit blocks in unfurling messages). But, Slack still supports old-fashioned unfurling messages which use Attachments, instead of Blocks. We had a talk with Slack guys and they assured us that they are not going to deprecate this. Some projects still use the old way for message unfurling and don't have plans to migrate to Block Kit in the near future.
As a temporary workaround, I've added a common interface to support both cases. The solution is not ideal, since
BlockOrAttachment
andChatUnfurlBlocksIF
represent different object families, but this is the easiest way to do this.