Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Attachment upon link unfurling #287

Merged
merged 2 commits into from
May 12, 2022
Merged

Conversation

zmarushchak-hs
Copy link
Contributor

The model for unfurling messages was recently updated to match the latest changes in Slack (using Block Kit blocks in unfurling messages). But, Slack still supports old-fashioned unfurling messages which use Attachments, instead of Blocks. We had a talk with Slack guys and they assured us that they are not going to deprecate this. Some projects still use the old way for message unfurling and don't have plans to migrate to Block Kit in the near future.
As a temporary workaround, I've added a common interface to support both cases. The solution is not ideal, since BlockOrAttachment and ChatUnfurlBlocksIF represent different object families, but this is the easiest way to do this.

@zmarushchak-hs zmarushchak-hs merged commit 62b2181 into master May 12, 2022
@zmarushchak-hs zmarushchak-hs deleted the hotfix-unfurl branch May 12, 2022 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants