Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HasChannel added to Leave and Join Events #265

Merged
merged 1 commit into from
Feb 2, 2022

Conversation

1carew1
Copy link
Contributor

@1carew1 1carew1 commented Feb 1, 2022

Adding HasChannel to SlackMemberJoinedChannelEvent and SlackMemberLeftChannelEvent

Copy link
Contributor

@omotnyk omotnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀 🚀 🚀

Comment on lines +163 to +168
@Test
public void itCanHaveAChannelWhenJoining() throws IOException {
SlackMemberJoinedChannelEvent event = fetchAndDeserializeSlackEvent("member_joined_private_channel.json").toDetailedEvent();
assertThat(event).isInstanceOf(HasChannel.class);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Comment on lines +183 to +188
@Test
public void itCanHaveAChannelWhenLeaving() throws IOException {
SlackMemberLeftChannelEvent event = fetchAndDeserializeSlackEvent("member_left_private_channel.json").toDetailedEvent();
assertThat(event).isInstanceOf(HasChannel.class);
}

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@1carew1 1carew1 merged commit 3c0f952 into master Feb 2, 2022
@1carew1 1carew1 deleted the add_has_channel_to_join_and_leave branch February 2, 2022 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants