Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add method for conversation kick api. #251

Merged
merged 2 commits into from
Nov 2, 2021

Conversation

higityan
Copy link
Contributor

Adding method for conversation kick api and unit tests for serializing/deserializing that jsons.

Copy link
Contributor

@omotnyk omotnyk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for adding the corresponding UTs 👍
LGMT 🚀
I left one small question.

{
"ok": true,
"response_metadata": {
"next_cursor": ""
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

QQ, why do we have this param in place? Is it to test that the model still works when the response contains a new unexpected field?

Copy link
Contributor Author

@higityan higityan Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Every slack response has that metadata. It contains some information about error message as I understand.

@higityan higityan removed the request for review from zmarushchak-hs November 2, 2021 06:20
@higityan higityan merged commit 1119790 into master Nov 2, 2021
@higityan higityan deleted the add_method_for_conversation_kick_api branch November 2, 2021 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants