Add reactions to conversation history #239
Conversation
| @JsonProperty("count") | ||
| Integer getCount(); | ||
| @JsonProperty("users") | ||
| List<String> getUser(); |
There was a problem hiding this comment.
Should we rename this to getUsers? I imagine the list is returned when multiple users reacted with the same emoji.
There was a problem hiding this comment.
Also, we won't need JsonProperty annotation in this case.
| @JsonProperty("name") | ||
| String getName(); | ||
| @JsonProperty("count") | ||
| Integer getCount(); | ||
| @JsonProperty("users") |
There was a problem hiding this comment.
We tend to use @JsonProperty only if the name of the method is different from JSON key.
In this case, we don't need to name each property explicitly since for example count is automatically deserialized and stored in getCount. That's the magic of the immutables.
| @JsonProperty("name") | ||
| String getName(); | ||
| @JsonProperty("count") | ||
| Integer getCount(); |
| "reactions": [ | ||
| { | ||
| "name": "astonished", | ||
| "count": 3, | ||
| "users": [ "U061F7AUR", "U062F7AUR", "U063F7AUR"] | ||
| }, | ||
| { | ||
| "name": "facepalm", | ||
| "count": 34, | ||
| "users": [ "U061F7AUR", "U062F7AUR", "U063F7AUR", "U064F7AUR", "U065F7AUR" ] | ||
| } | ||
| ] |
There was a problem hiding this comment.
Thanks for adding these.
Can we also please make sure that these reactions are parsed in the corresponding integration test?
|
Thanks for the quick feedback @omotnyk. I addressed the previous comments so feel free to take a second look. |
| assertThat(response.getMessages().get(1).getReactions().size()).isEqualTo(2); | ||
| assertThat(response.getMessages().get(1).getReactions().get(0).getName()).isEqualTo("astonished"); | ||
| assertThat(response.getMessages().get(1).getReactions().get(0).getCount()).isEqualTo(3); | ||
| assertThat(response.getMessages().get(3).getReactions().get(1).getUsers()).isEqualTo(Arrays.asList("U061F7AUR", "U062F7AUR", "U063F7AUR")); |
There was a problem hiding this comment.
Let's either assert that facepalm reaction is deserialized correctly here as well or remove it from the JSON fixture.
Added reactions to the
LiteMessagemodel to be able to retrieve the list or reactions attached to a slack message.