Call update/remove Slack message methods without as_user param for V2 bot token
#224
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
omotnyk
reviewed
Apr 12, 2021
|
|
||
| @JsonProperty("ts") | ||
| public abstract String getMessageToDeleteTs(); | ||
| public abstract class AbstractChatDeleteParams extends AbstractChatDeleteParamsBase { | ||
|
|
||
| @Default | ||
| @JsonProperty("as_user") |
There was a problem hiding this comment.
The current solution is 👍 but I wonder what do you think about annotating this property with @JsonInclude(Include.NON_DEFAULT)? This annotation says that if the value is the default we won't be serializing the property.
There was a problem hiding this comment.
Good point, didn't know about this annotation.
omotnyk
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slack fails to execute method if
as_userparam is present and V2 bot token is used. Models updated to have the possibility to not include this param forchat.deleteandchat.updatemethods.