Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added support of channel_shared event #217

Merged
merged 2 commits into from
Mar 26, 2021
Merged

Conversation

leonidhladii
Copy link
Contributor

Problem
Missing channel_shared event.

Description
Added support of channel shared event to SlackEventType

Copy link
Contributor

@zmarushchak-hs zmarushchak-hs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see my comments inlined.


@Value.Immutable
@HubSpotStyle
@JsonNaming(SnakeCaseStrategy.class)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please correct me if I'm wrong, but I think we don't need @JsonNaming(SnakeCaseStrategy.class) if we have @JsonProperty("connected_team_id") set for the field.

"authed_users": [
"UBRFHDFGA"
]
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

New line, please.

@leonidhladii leonidhladii merged commit 2bcdb3b into master Mar 26, 2021
@leonidhladii leonidhladii deleted the slack_shared_channel branch March 26, 2021 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants