Store temporary macro function result vars #920
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently if there is a macro function that cannot be fully evaluated and it's used in a situation where partial evaluation is not an option, the evaluation result will be discarded. For example:
If calling
caller()
had some deferred tokens, we would have to discard the result because we couldn't run the filter on the non-fully evaluated macro result. This meant that the macro function would need to get run again later, which was expensive and could cause some issues if the function was not idempotent.Instead, if the result is stored, we can convert it to:
This reduces the duplication of work needed, leading to a faster final render and a faster initial render in many circumstances.