Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reintroduce operator precedence fix with legacy override #902

Merged
merged 18 commits into from
Jul 28, 2022

Conversation

tkindy
Copy link
Contributor

@tkindy tkindy commented Jul 28, 2022

Closes #893

This PR is basically #895 but with the changes disabled by default. They can be enabled by setting a new flag on LegacyOverrides as part of the JinjavaConfig.

@tkindy tkindy marked this pull request as ready for review July 28, 2022 14:57
@tkindy tkindy requested review from jasmith-hs and removed request for jasmith-hs July 28, 2022 14:57
@tkindy tkindy marked this pull request as draft July 28, 2022 14:58
@tkindy
Copy link
Contributor Author

tkindy commented Jul 28, 2022

Actually, I want to move some of the tests around first.

@tkindy tkindy marked this pull request as ready for review July 28, 2022 15:15
@tkindy tkindy requested a review from jasmith-hs July 28, 2022 15:16
Comment on lines +643 to +646
@FunctionalInterface
private interface ParseLevel {
AstNode apply(boolean required) throws ScanException, ParseException;
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, I'm glad! 😄

@tkindy tkindy merged commit 5cb58e9 into master Jul 28, 2022
@tkindy tkindy deleted the tk/reintro-precedence-fix branch July 28, 2022 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unary minus binds too loosely
2 participants