Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* judge whitespace after {%, {#, {{ #773

Merged
merged 4 commits into from
Nov 12, 2021
Merged

* judge whitespace after {%, {#, {{ #773

merged 4 commits into from
Nov 12, 2021

Conversation

bes2008
Copy link
Contributor

@bes2008 bes2008 commented Nov 8, 2021

  • judge whitespace after {%, {#, {{

fix the bug: #772

@bes2008 bes2008 closed this Nov 9, 2021
@bes2008 bes2008 reopened this Nov 9, 2021
@@ -9,11 +9,13 @@
private final boolean evaluateMapKeys;
private final boolean iterateOverMapKeys;
private final boolean usePyishObjectMapper;
private final boolean useWhitespaceAfterStartToken;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think a better name might be whitespaceRequiredWithinTokens as it makes it sound more like it changes how input whitespace is used rather than how whitespace is output

@bes2008
Copy link
Contributor Author

bes2008 commented Nov 12, 2021

rename it, useWhitespaceAfterStartToken -> whitespaceRequiredWithinTokens

@jasmith-hs jasmith-hs merged commit b72dd95 into HubSpot:master Nov 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants