Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Issue 491: Support IN operator for dictionaries #493

Merged
merged 2 commits into from
Aug 31, 2020
Merged

Issue 491: Support IN operator for dictionaries #493

merged 2 commits into from
Aug 31, 2020

Conversation

akhismat
Copy link
Contributor

Check if the dictionary contains the required key.

@akhismat akhismat mentioned this pull request Aug 26, 2020
Closed
boulter
boulter requested changes Aug 26, 2020
View reviewed changes
Copy link
Contributor

@boulter boulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. I know there aren't any existing tests for this class, but could you add some for your change?

@akhismat akhismat requested a review from boulter August 31, 2020 15:01
boulter
boulter approved these changes Aug 31, 2020
View reviewed changes
Copy link
Contributor

@boulter boulter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks and nice job!

@boulter boulter merged commit 0f0cd8d into HubSpot:master Aug 31, 2020
@akhismat akhismat deleted the issue/491/in-operator-for-dictionaries branch September 16, 2020 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@boulter boulter boulter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akhismat @boulter