Upgrade map filter to advanced filter, improve error messages, and pass through args for filters #356
+104
−10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattcoley
changed the title
boulter
approved these changes
Aug 1, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
|mapfilter supports two usages: mapping to an attribute and mapping to a filter. Since|mapwas a regular filter, it could not use theattribute=arg to specify if the argument is an attribute and not a filter if there was ambiguity between the two. This upgrades the map filter to an advanced filter and improves on error messaging by preventing NPEs from surfacing if a null value is passed into the filter.The docs also say
Alternatively you can let it invoke a filter by passing the name of the filter and the arguments afterwardswhich was not true until I added the passthrough of the additional arguments.