Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow tags to declare themselves safe for execution in validation mode #273

Merged
merged 1 commit into from
Jan 10, 2019
Merged

Allow tags to declare themselves safe for execution in validation mode #273

merged 1 commit into from
Jan 10, 2019

Conversation

boulter
Copy link
Contributor

@boulter boulter commented Jan 10, 2019

Reimplements #264 for tags by allowing them to override isRenderedInValidationMode so "safe" tags will be executed and other tags can opt in to execute.

@boulter boulter requested review from mattcoley and hs-lsong January 10, 2019 20:56
mattcoley
mattcoley approved these changes Jan 10, 2019
View reviewed changes
Copy link
Collaborator

@mattcoley mattcoley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, better solution than what we were doing before.

@boulter boulter merged commit 94f1c09 into master Jan 10, 2019
@boulter boulter deleted the validation-mode-for-tags branch January 10, 2019 21:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcoley mattcoley mattcoley approved these changes

@hs-lsong hs-lsong hs-lsong approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@boulter @mattcoley @hs-lsong @jboulter