Add configurable random number generator #135
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hs-lsong
approved these changes
Aug 2, 2017
| while (index-- > 0) { | ||
| it.next(); | ||
| } | ||
| return it.next(); | ||
| } | ||
| // number | ||
| if (object instanceof Number) { | ||
| return ThreadLocalRandom.current().nextLong(((Number) object).longValue()); | ||
| return interpreter.getRandom().nextInt(((Number) object).intValue()); |
There was a problem hiding this comment.
Why changing long to int here?
There was a problem hiding this comment.
There's no nextLong() that takes a bound in java.util.Random. I figured random ints are probably big enough.
| } | ||
| // string | ||
| if (object instanceof String) { | ||
| try { | ||
| return ThreadLocalRandom.current().nextLong(new BigDecimal((String) object).longValue()); | ||
| return interpreter.getRandom().nextInt(new BigDecimal((String) object).intValue()); |
| @@ -2,27 +2,31 @@ | |||
|
|
|||
| import static org.assertj.core.api.Assertions.assertThat; | |||
| import static org.assertj.core.api.Assertions.failBecauseExceptionWasNotThrown; | |||
| import static org.mockito.Mockito.*; | |||
There was a problem hiding this comment.
import static org.mockito.Mockito.when should be enough.
There was a problem hiding this comment.
Our style is to always collapse imports for Mockito and a few other deps.
|
LGTM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Useful for testing when you want to compare against known values.
@hs-lsong @pfarrel @jmagnarelli-hs